134 breaking remove unicode characters #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 97.00% 96.39% -0.62%
==========================================
Files 22 22
Lines 734 776 +42
==========================================
+ Hits 712 748 +36
- Misses 22 28 +6 ☔ View full report in Codecov by Sentry. |
pat-alt
reviewed
Nov 28, 2024
There was a problem hiding this comment.
LGTM 👍🏽 might be worth addressing a few things though since this is a major release:
- Add some additional detail to the CHANGELOG
- Add tests to ensure that accessing fields through aliases still works
- Making sure that everywhere in the code base we access fields using their new names, instead of the aliases (since this is meant purely for usability)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed scitypes, added aliases, changed changelog.